jann/m2dev-client-src
1
0
Fork 0
forked from metin-server/m2dev-client-src
Code Pull Requests Activity

Merge pull request #82 from MindRapist/mr-8

Browse Source 
MR-8: Fix semi-transparent effects
This commit is contained in:
rtw1x1
2026-01-20 22:55:30 +00:00
committed by GitHub
parent 7d0b5d545d 4df27653da
commit 4e41646822
4 changed files with 1 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
README.md
View File

@@ -13,7 +13,4 @@ This repository contains the source code necessary to compile the game client ex
## 📋 Changelog ## 📋 Changelog
### 🐛 Bug Fixes ### 🐛 Bug Fixes
* **Amun's freeze on drag window**: Fixed a bug where the client window would freeze while we are dragging it around. * **Effect adapting to semi-transparent meshes:** Effect adapting to semi-transparent meshes has been removed as it was causing artifacts when opacity was lower than 1
* **Debug mode:** Fly effects are now registering when using Debug mode.
* **Fix effect rendering in low opacity models:** Effects now appear normally on semi-transparent meshes.
* **Fly targeting fixed for buff/healing skills:** Fixed an issue where fly target effect would render in the buffer's selected target even if the target was unbuffable (if viewing from another client).

11
src/EffectLib/EffectManager.cpp
View File

@@ -351,17 +351,6 @@ void CEffectManager::HideEffect()
m_pSelectedEffectInstance->Hide(); m_pSelectedEffectInstance->Hide();
} }
// MR-5: Fix effect rendering when actor is semi-transparent
// Credits to d1str4ught
void CEffectManager::RenderEffect()
{
if (!m_pSelectedEffectInstance)
return;
m_pSelectedEffectInstance->Render();
}
// MR-5: -- END OF -- Fix effect rendering when actor is semi-transparent
void CEffectManager::ApplyAlwaysHidden() void CEffectManager::ApplyAlwaysHidden()
{ {
if (!m_pSelectedEffectInstance) if (!m_pSelectedEffectInstance)

4
src/EffectLib/EffectManager.h
View File

@@ -56,10 +56,6 @@ class CEffectManager : public CScreen, public CSingleton<CEffectManager>
void ShowEffect(); void ShowEffect();
void HideEffect(); void HideEffect();
// MR-5: Fix effect rendering when actor is semi-transparent
// Credits to d1str4ught
void RenderEffect();
// MR-5: -- END OF -- Fix effect rendering when actor is semi-transparent
void ApplyAlwaysHidden(); void ApplyAlwaysHidden();
void ReleaseAlwaysHidden(); void ReleaseAlwaysHidden();

12
src/GameLib/ActorInstanceRender.cpp
View File

@@ -36,18 +36,6 @@ void CActorInstance::OnRender()
if (!m_pkCurRaceData) if (!m_pkCurRaceData)
return; return;
// MR-5: Fix effect rendering when actor is semi-transparent
// Credits to d1str4ught
if (GetAlphaValue() < 1.0f)
{
for (auto it = m_AttachingEffectList.begin(); it != m_AttachingEffectList.end(); ++it)
{
CEffectManager::Instance().SelectEffectInstance(it->dwEffectIndex);
CEffectManager::Instance().RenderEffect();
}
}
// MR-5: -- END OF -- Fix effect rendering when actor is semi-transparent
D3DMATERIAL9 kMtrl; D3DMATERIAL9 kMtrl;
STATEMANAGER.GetMaterial(&kMtrl); STATEMANAGER.GetMaterial(&kMtrl);