diff --git a/README.md b/README.md index 356e742..b6250de 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,4 @@ This repository contains the source code necessary to compile the game client ex ## 📋 Changelog ### 🐛 Bug Fixes -* **Amun's freeze on drag window**: Fixed a bug where the client window would freeze while we are dragging it around. -* **Debug mode:** Fly effects are now registering when using Debug mode. -* **Fix effect rendering in low opacity models:** Effects now appear normally on semi-transparent meshes. -* **Fly targeting fixed for buff/healing skills:** Fixed an issue where fly target effect would render in the buffer's selected target even if the target was unbuffable (if viewing from another client). +* **Effect adapting to semi-transparent meshes:** Effect adapting to semi-transparent meshes has been removed as it was causing artifacts when opacity was lower than 1 diff --git a/src/EffectLib/EffectManager.cpp b/src/EffectLib/EffectManager.cpp index de393cb..2037c39 100644 --- a/src/EffectLib/EffectManager.cpp +++ b/src/EffectLib/EffectManager.cpp @@ -351,17 +351,6 @@ void CEffectManager::HideEffect() m_pSelectedEffectInstance->Hide(); } -// MR-5: Fix effect rendering when actor is semi-transparent -// Credits to d1str4ught -void CEffectManager::RenderEffect() -{ - if (!m_pSelectedEffectInstance) - return; - - m_pSelectedEffectInstance->Render(); -} -// MR-5: -- END OF -- Fix effect rendering when actor is semi-transparent - void CEffectManager::ApplyAlwaysHidden() { if (!m_pSelectedEffectInstance) diff --git a/src/EffectLib/EffectManager.h b/src/EffectLib/EffectManager.h index 0014cef..fb7e245 100644 --- a/src/EffectLib/EffectManager.h +++ b/src/EffectLib/EffectManager.h @@ -56,10 +56,6 @@ class CEffectManager : public CScreen, public CSingleton void ShowEffect(); void HideEffect(); - // MR-5: Fix effect rendering when actor is semi-transparent - // Credits to d1str4ught - void RenderEffect(); - // MR-5: -- END OF -- Fix effect rendering when actor is semi-transparent void ApplyAlwaysHidden(); void ReleaseAlwaysHidden(); diff --git a/src/GameLib/ActorInstanceRender.cpp b/src/GameLib/ActorInstanceRender.cpp index e6e703a..3da5fda 100644 --- a/src/GameLib/ActorInstanceRender.cpp +++ b/src/GameLib/ActorInstanceRender.cpp @@ -36,18 +36,6 @@ void CActorInstance::OnRender() if (!m_pkCurRaceData) return; - // MR-5: Fix effect rendering when actor is semi-transparent - // Credits to d1str4ught - if (GetAlphaValue() < 1.0f) - { - for (auto it = m_AttachingEffectList.begin(); it != m_AttachingEffectList.end(); ++it) - { - CEffectManager::Instance().SelectEffectInstance(it->dwEffectIndex); - CEffectManager::Instance().RenderEffect(); - } - } - // MR-5: -- END OF -- Fix effect rendering when actor is semi-transparent - D3DMATERIAL9 kMtrl; STATEMANAGER.GetMaterial(&kMtrl);