metin-server/m2dev-server-src
3
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge pull request #22 from rtw1x1/main

Browse Source 
Fix buffer overflow in QUERY_PLAYER_CREATE
This commit is contained in:
d1str4ught
2025-11-21 22:41:36 +01:00
committed by GitHub
parent 08b93e2ec8 aded93fe68
commit da619922cb
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/db/ClientManagerPlayer.cpp
View File

@@ -1,4 +1,4 @@
#include "stdafx.h" #include "stdafx.h"
#include "ClientManager.h" #include "ClientManager.h"
@@ -893,7 +893,8 @@ void CClientManager::__QUERY_PLAYER_CREATE(CPeer *peer, DWORD dwHandle, TPlayerC
packet->player_table.ht, packet->player_table.ht,
packet->player_table.job); packet->player_table.job);
static char text[4096 + 1]; //tw1x1: Buffer overflow (14.11.2025 / 21:08 GMT)
static char text[8192 + 1];
CDBManager::instance().EscapeString(text, packet->player_table.skills, sizeof(packet->player_table.skills)); CDBManager::instance().EscapeString(text, packet->player_table.skills, sizeof(packet->player_table.skills));
queryLen += snprintf(queryStr + queryLen, sizeof(queryStr) - queryLen, "'%s', ", text); queryLen += snprintf(queryStr + queryLen, sizeof(queryStr) - queryLen, "'%s', ", text);